Bookmarks, CoverBrowser: scale dogear icon#4081
Conversation
The Dogear icon is 20x20 pixels and was never scaled where used. Now: The bookmark icon (top right of screen) is scaled to 1/32th of the screen width (previously, it was 1/30th on a 600px wide emulator, 1/53th on a GloHD). On CreDocument, furthermore decrease its size if needed depending on the selected margins so it never overwrite the text. CoverBrowser list view: scale it to the available room under the "N % of P page" text, so it does not cover "page". CoverBrowser mosaic view: scale it to 1/16th of the cover rectangle, which should prevent if from overwritting the text thanks to a max text width of 7/8 of the cover rectangle. Also for CoverBrowser: don't index metadata for unsupported document (which could happen when browsing files with PathChooser) and show full filename for such documents. Also: ImageWidget: small fix in case we use both scale_factor and scale_for_dpi.
|
since version v2015.11.1785 the doger icon appears too small on my aura one. what parameter is it necessary to modify to change its size? |
|
I guess you meant to write: my dogear icon appears too small :) Your icon from #4046 (comment) is 70 pixels. Previously, it wasn't scaled, so it appeared at 70 pixels. Since v2015.11.1785, the dogear icon (yours and our original one) is scaled to 1/32 of the screen width. If you really want even bigger, you'd need to change manually the |
|
this change has no effect on the size of my deager icon. |
|
OK, so for EPUBs, it is furthermore limited by the page margins, in order to not override any text. function ReaderDogear:onReadSettings(config)
if true then return end -- ADD THIS LINE
if not self.ui.document.info.has_pages then
[...]
function ReaderDogear:onSetPageMargins(margins)
if true then return end -- ADD THIS LINE
if self.ui.document.info.has_pages then |
|
can you tell me which file is concerned? thank you |
|
The same file that you modified earlier : koreader/frontend/apps/reader/modules/readerdogear.lua |
|
Apparemment, ça fait planter koreader |
|
Cela veut dire probablement que vous avez accidentellement introduit une erreur de syntaxe. Qu'est-ce que c'est l'erreur ? |
|
Replace the file with this one (remove the .txt at the end): readerdogear.lua.txt |
|
impeccable, thank you! |
The Dogear icon is 20x20 pixels and was never scaled where used. Now:
The bookmark icon (top right of screen) is scaled to 1/32th of the screen width (previously, it was 1/30th on a 600px wide emulator, 1/53th on a GloHD).
So, it should stay the same size on a small emulator, and become 2 times bigger on a 1000px device.
1/32 looks like this:
On CreDocument, furthermore decrease its size if needed depending on the selected margins so it never overwrite the text (as margins are scaled for DPI, this somehow scale the icon for dpi too).
=> 
Before => after
CoverBrowser list view: scale it to the available room under the "N % of P page" text, so it does not cover "page".
=> 
CoverBrowser mosaic view: scale it to 1/16th of the cover rectangle, which should prevent if from overwritting the text thanks to a max text width of 7/8 of the cover rectangle.
=>
The above CoverBrowser screenshots were made on the emulator, and the icon size looks divided by 2. But the after size is actually how it looked before and still looks after on a GloHD.
Also for CoverBrowser: don't index metadata for unsupported document (which could happen when browsing files with PathChooser) and show full filename for such documents.
Also: ImageWidget: small fix in case we use both scale_factor and scale_for_dpi.
The 1/32 (for bookmark icons) and 1/16 (for coverbrowser mosaic view) can be changed if people find it too big or too small (they fit my liking, I like things small, but strangely, I don't bother the bigger bookmark icon).
Close #3265. Close #4046.