Add horizontal_padding to IconButton#3213
Merged
Frenzie merged 1 commit intokoreader:masterfrom Sep 13, 2017
Merged
Conversation
TouchMenu (top menu) and ConfigDialog (bottom menu) updated to make use of that. This provides a wider sensitivity to menu buttons.
Member
|
Looks good. I'll test it tomorrow. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3194 (comment) and next comment.
Added padding to IconButton, so that icon image and this padding are tapable.
TouchMenu (top menu) and ConfigDialog (bottom menu) updated to make use of that. This provides a wider sensitivity to menu buttons.
Top menu looks unchanged. Noticed a thing that was already there: the line under icons does not go as far to the right screen border as it does on the left. Couldn't figure how to fix that (didn't really understand the
bar_sepbusiness there...)For the bottom menu, we should choose how wide we want the icons (3 alternatives in the code: i let in something similar to top menu).