Show position on config panel#3194
Conversation
|
Would be nice if both top and bottom menus had a similar way of showing the active icon. |
Not just that. It also has the lines on the side. ;-) I'll have to try this on my device, but I suspect that rather than a plain invert I would prefer a dark gray like in the MultiSelects (or whatever they're called) in the menu itself. If we choose to go for this style, that is. |
|
I think the matching grey indicator is a little more consistent and obvious, but the last approach also is consistent with the top menu treatment. |
frontend/ui/widget/configdialog.lua
Outdated
| local spacing_line = LineWidget:new{ | ||
| dimen = Geom:new{ | ||
| w = spacing_width, | ||
| h = 2, |
There was a problem hiding this comment.
Shouldn't this one be icon_sep_width?
Sorry, not that value, but scaled and probably a variable for reuse on the other h=2s?
frontend/ui/widget/configdialog.lua
Outdated
| local menu_items = {} | ||
| local icons_width = 0 | ||
| local icons_height = 0 | ||
| local line_thickness = 2 |
There was a problem hiding this comment.
Like I said though, shouldn't it also be given the scaleBySize treatment? :-)
|
@poire-z Btw, I don't think those ImageWidgets are scaling properly? Edit: @robert00s Not a typo this time; @poire-z is responsible for the most recent ImageWidget changes. ;-) |
|
I don't have a monitor big enough to reproduce what you show :) koreader/frontend/ui/widget/configdialog.lua Lines 415 to 417 in a720eac Also, I don't know much about dpi mathematics, but when I checked the following, I think I remember it was multiplying by 2 at most: koreader/frontend/ui/widget/imagewidget.lua Lines 178 to 182 in a720eac |
|
@poire-z I get what looks like good results by removing the flooring. BeforeAfterEdit: Doesn't look too shabby with a custom DPI either, although it has some beauty flaws (not the ImageWidget, but the GUI in general). |
|
@Frenzie shouldn't be bordersize = Screen:scaleBySize(2),? |
|
Yes, that is good. But like you said, don't do it in ConfigDialog and fix FrameContainer instead. 👍 |
| local Device = require("device") | ||
| local Geom = require("ui/geometry") | ||
| local WidgetContainer = require("ui/widget/container/widgetcontainer") | ||
| local Screen = Device.screen |
There was a problem hiding this comment.
Nitpick, but if you only need screen then local Screen = require("device").screen is fine. ;-)
| radius = 0, | ||
| bordersize = 2, | ||
| bordersize = Screen:scaleBySize(2), | ||
| padding = 5, |
|
Thanks! |
|
Noticed 2 things: icons move a few pixels left or right upon selection/unselection, and the selected icon looks to me a bit tight between its 2 vertical lines. |
|
Could you make sure the padding is touchable? The top menu also wants that treatment. ;-) |







Actually we don't know on which panel we are (in config panel). After this change we have inverted button to show which panel we use.


Before:
After: