Newsdownloader: add HTTPS support and fixes#3072
Merged
Frenzie merged 1 commit intokoreader:masterfrom Aug 11, 2017
Merged
Conversation
Member
Frenzie
commented
Aug 11, 2017
- Fixes [feature request] support https urls in news (RSS / Atom) downloader #3041 (HTTPS)
- Fixes unlimited (limit = 0) was broken
- Fixes titles and links with attributes
Member
Author
|
@mwoz123 Since you are the most familiar with this code I'd appreciate it if you could check if I didn't accidentally break anything. (Ideally that's where unit tests come in.) |
* Fixes koreader#3041 (HTTPS) * Fixes unlimited (limit = 0) was broken * Fixes titles and links with attributes
ab9510d to
3e436aa
Compare
Frenzie
commented
Aug 11, 2017
| local logger = require("logger") | ||
| local ltn12 = require("ltn12") | ||
| local LuaSettings = require("frontend/luasettings") | ||
| local socket_url = require("socket.url") |
Member
Author
There was a problem hiding this comment.
I figured it was easier to use socket_url here than to change all of the already existing urls to something else.
mwoz123
approved these changes
Aug 11, 2017
Contributor
mwoz123
left a comment
There was a problem hiding this comment.
As far as I know lua (basics) looks ok.
Member
Author
|
All right, I'll just go ahead and merge this so it'll be in the next nightly then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.