OPDS: fix crash on feeds with single-quoted XML attributes#15068
Merged
Conversation
Add a CCLASS_SQUOTE character class and ST_ATTR_VAL_SQ state to the lexer FSM so single-quoted attributes are parsed correctly without cross-matching with double-quoted ones. Both quoting styles are valid XML per the spec.
Add a nil check on entry URL in getSyncDownloadList to prevent a crash when a feed entry has no navigation link. Add a test for single-quoted attribute feeds.
d1665e7 to
174b3f9
Compare
Member
|
Possibly worth noting there's a competing parser hiding in the codebase. Someday we'll need to do something about that… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14571.
The luxl XML lexer only recognizes double-quoted attribute values (
"), so single-quoted ones (') cause the parser to enter an error state and silently drop all remaining entries and their links. This PR adds aCCLASS_SQUOTEcharacter class andST_ATTR_VAL_SQstate to the luxl FSM so single-quoted attributes are parsed correctly without cross-matching. It also adds a nil guard onentry.urlingetSyncDownloadListto prevent a crash when an entry has no navigation link.This change is