Switch virtual_keyboard_enabled default to false on hasKeyboard and hasScreenKB#15056
Switch virtual_keyboard_enabled default to false on hasKeyboard and hasScreenKB#15056Frenzie wants to merge 1 commit into
Conversation
Commodore64user
left a comment
There was a problem hiding this comment.
I think this is still not quite enough though
| help_text = _("Enable this setting to always display the virtual keyboard within a text input field. When a field is selected (in focus), you can temporarily toggle the keyboard on/off by pressing 'Shift' (or 'ScreenKB') + 'Home'."), | ||
| checked_func = function() | ||
| return G_reader_settings:nilOrTrue("virtual_keyboard_enabled") | ||
| return G_reader_settings:isTrue("virtual_keyboard_enabled") |
There was a problem hiding this comment.
I'm afraid this value is never actually set to True, is only ever nil or false
There was a problem hiding this comment.
the flip below this should also change
| self.deny_keyboard_hiding = true | ||
| end | ||
| if (Device:hasKeyboard() or Device:hasScreenKB()) and G_reader_settings:isFalse("virtual_keyboard_enabled") then | ||
| if (Device:hasKeyboard() or Device:hasScreenKB()) and G_reader_settings:nilOrFalse("virtual_keyboard_enabled") then |
There was a problem hiding this comment.
there are also other stops just like this one... in other files
There was a problem hiding this comment.
They all already say that.
| keep_menu_open = true, | ||
| enabled_func = function() | ||
| return G_reader_settings:nilOrTrue("virtual_keyboard_enabled") | ||
| return not (Device:hasKeyboard() or Device:hasScreenKB()) and G_reader_settings:nilOrTrue("virtual_keyboard_enabled") or false |
There was a problem hiding this comment.
So, this menu won't be enabled on the emulator?
We can't style the Shift+Home VK ? We can't even test the VK when developping ?
There was a problem hiding this comment.
I won't make a release with the behavior in the condition it is now. It either needs to be reverted to a working condition or fixed up to a working condition.
|
Forget it, I don't want to make this change in the first place. |
|
You could migrate every one to false... Why don't you want to change the default? |
|
To be precise I'm not the least bit motivated to personally spend time on that specifically, at least today. I don't know why really. |
|
Do you want me to switch the default though? Mind you hasScreenKB should not default to false |
|
In principle hasKeyboard should default to not showing, since why would a desktop app do that, while isEmulator should default to showing. Chances are I'll recover my motivation tomorrow or the day after, but if you wish to do it sooner that'd be cool. :-) |
Without this change we can't do a release, as requested by @poire-z in #15051 (comment).
@Commodore64user Please check this carefully as well. :-)
This change is