progressbardialog: improvements#14513
Conversation
| UIManager:close(self) | ||
| end | ||
| end | ||
| ProgressbarDialog.onAnyKeyPressed = ProgressbarDialog.onDismiss |
There was a problem hiding this comment.
Don’t we normally add an id = “close” instead? I’m not sure we any all buttons to close it, also aren’t the continue and cancel buttons inverted? Cancel is usually on the left
| ok_text = _("Cancel"), | ||
| ok_callback = function() | ||
| self.dismiss_box = nil | ||
| UIManager:close(self) | ||
| end, | ||
| cancel_text = _("Continue"), | ||
| cancel_callback = function() |
There was a problem hiding this comment.
I agree with @Commodore64user observation:
also aren’t the continue and cancel buttons inverted? Cancel is usually on the left
but I guess it's on purpose : continue = cancel the dismiss :) ok = do dismiss. May be some small comment explaining that will make us not stop on it and wonder :)
There was a problem hiding this comment.
Yes, so tapping outside the confirmation dialog cancel the cancellation. But I went and changed the buttons so "Cancel" is on the left (and disabled dismissing the confirmation so you can't dismiss the confirmation and cancel the operation by tapping elsewhere).
9636767 to
b015e72
Compare
b015e72 to
1021dbd
Compare
|
@poire-z Were you okay with it? |
So `reportProgress` returns true when the progress bar was actually updated.
1021dbd to
d007c9a
Compare
This change is