bump base & crengine: fix buildSyntheticPageMap()#14476
Merged
Conversation
Includes: - ci/circle: speed up lint phase - tests: fix test runner handling of `--wrapper` option - ci/macos: update jobs - bump crengine: fix buildSyntheticPageMap()
collectFaceInfo() can return an empty table {},
which could cause readerfont.lua's onSetFont()
to crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump base & crengine: fix buildSyntheticPageMap()
Includes:
--wrapperoption tests: fix test runner handling of--wrapperoption koreader-base#2195Solves problem described at Statistics: fix getCurrentBookReadPages() when use_pagemap_for_stats #14426 (comment)
Fontlist: really ignore invalid fonts
collectFaceInfo() can return an empty table
{}, which could cause readerfont.lua's onSetFont() to crash.Closes #14462.
This just avoids the crash, the problematic font may appear with a blank name in ReaderFont menu list (because crengine gathers fonts on its own with some different logic) and selecting it would just have no effect.
This change is