gettext: switch to binary catalogs#13967
Merged
Frenzie merged 2 commits intoJun 21, 2025
Merged
Conversation
32e9705 to
0c2b89e
Compare
Member
|
I suppose that's okay, but of course it does remove the user's ability to (easily) edit translations to see what happens. |
Member
Author
|
It depends on the workflow, e.g. when using poedit the binary catalog is automatically generated/updated on save. I don't think anybody was really editing po files directly on targets like a Kindle or Kobo. |
0c2b89e to
a2c5d39
Compare
Frenzie
reviewed
Jun 21, 2025
Frenzie
reviewed
Jun 21, 2025
Binary catalogs are more space efficient (total translations disk usage: 14MB instead of 35MB), and easier and faster (roughly 10 times) to load: no parsing, and less processing (no need to unescape strings). Not much difference on the Android APK size (a ~600KB reduction), but other TAR.GZ / ZIP distributions see a reduction of ~3.5MB.
Make sure we don't include some gettext tests leftovers.
a2c5d39 to
3ef7c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary catalogs are more space efficient (total translations disk usage: 14MB instead of 35MB), and easier and faster (roughly 10 times) to load: no parsing, and less processing (no need to unescape strings).
Not much difference on the Android APK size (a ~600KB reduction), but other TAR.GZ / ZIP distributions see a reduction of ~3.5MB.
This change is