gettext: fix handling of fuzzy translations#13966
Merged
Frenzie merged 2 commits intoJun 20, 2025
Merged
Conversation
The code would incorrectly load part of them, examples: - the fuzzy translation is not ignored (because of the context, which is itself ignored): ``` msgctxt "Status of group of books" msgid "All" msgstr "Kaikki" ``` - not ignored, with an invalid original string (`"Please configure it in the settings."`): ```po msgid "" "The download folder is not valid.\n" "Please configure it in the settings." msgstr "" "Le répertoire de téléchargement est invalide.\n" "Veuillez le configurer dans les paramètres." ``` - and in this case the second fuzzy entry end up overwriting the valid translation (with `"لم يتم حفظ الملف في:\n%1"`): ```po msgid "" "%1\n" "%2" msgstr "" "%1\n" "%2" msgid "" "Could not save file to:\n" "%1\n" "%2" msgstr "" "لم يتم حفظ الملف في:\n" "%1" ```
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code would incorrectly load part of them, examples:
"Please configure it in the settings."):"لم يتم حفظ الملف في:\n%1"):This change is