Skip to content

update building & testing docs + kodev tweak#13953

Merged
Frenzie merged 3 commits into
koreader:masterfrom
benoit-pierre:pr/update_building_docs_+_kodev_tweak
Jun 14, 2025
Merged

update building & testing docs + kodev tweak#13953
Frenzie merged 3 commits into
koreader:masterfrom
benoit-pierre:pr/update_building_docs_+_kodev_tweak

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Jun 14, 2025

Copy link
Copy Markdown
Member

This change is Reviewable

- remove unnecessary LUA requirements already provided by the build system
- clarify necessary vs optional requirements
- simplify macOS instructions around the minimum targeted deployment version
There's no need for messing with the LUA environment using luarocks
anymore, since all testing requirements are already provided by the
build system, and luacheck can be run with a different LUA version
than the one being checked.
@benoit-pierre benoit-pierre requested a review from Frenzie as a code owner June 14, 2025 10:45
@benoit-pierre benoit-pierre changed the title update building docs + kodev tweak update building & testing docs + kodev tweak Jun 14, 2025
@benoit-pierre

Copy link
Copy Markdown
Member Author

Weird leftovers from the newsdownloader test are breaking the macOS builds:

▸ ls koreader-emulator-x86_64-pc-linux-gnu-debug/koreader | grep Feed
nilSingle Item Atom Feed/
nilSingle Item Feed/

@Frenzie Frenzie merged commit 4dc4339 into koreader:master Jun 14, 2025
2 of 4 checks passed
@Frenzie

Frenzie commented Jun 14, 2025

Copy link
Copy Markdown
Member

Thanks, good work.

@Frenzie Frenzie added this to the 2025.06 milestone Jun 14, 2025
@benoit-pierre benoit-pierre deleted the pr/update_building_docs_+_kodev_tweak branch June 15, 2025 04:52
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants