NewsDownloader: Include author's name in summary when "Download full article"=false#13842
Merged
Conversation
Frenzie
reviewed
May 23, 2025
| authors[i] = feed.author[i].name | ||
| end | ||
| if #authors > 0 then | ||
| return "By " .. table.concat(authors, ", ") |
Member
There was a problem hiding this comment.
It'll be less effort wrt translations and imo it looks better without adding 'by'.
Frenzie
approved these changes
May 23, 2025
Frenzie
left a comment
Member
There was a problem hiding this comment.
Oh, that was the the next commit. ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an RSS feed is downloaded with "Download full article"=false, the author's name is not included in the resulting EPUB.
Two common ways of marking up the authors' name are:
<author><name>Author Name</name></author><dc:creator> Author One and Author Two </dc:creator>This change adds a function that looks for one or more names in one of the above formats and adds a byline with the names to the HTML. The line break
<br>was added to ensure there is at least some space between the byline and the content of the article, even if the content is not enclosed by<p>.This change is