css_tweaks: Reimplement smaller inpage footnotes #13639
Conversation
00016dd to
8eeb037
Compare
I don't really like the code side of things for that reason, but would you happen to have one or two screenshots of what the menu looks like? |
|
Sorry, still a bit too busy to dig in (and see how I like it or not).
Here's one (shared a long time ago around here): Proffer_Klyuchi-k-Lolite-.EeRvzA.159923.zip About the difference in font size for footnotes vs endnotes (notes vs. comments), let's ask @hius07 @mergen3107 how much this is needed and nice. |
|
Screenshots: 
As I said, #13613 might be better. But @poire-z's comments made me curious if there's a good way to do this. The other option would be to duplicate all the footnote size tweaks to have a variant that forces the size for all block children and one that just sets it on the root element. A lot more tweaks but it's in a submenu. That also allows dropping the "smaller" versions from the top level menu. |
| if global_tweaks["font-size_" .. pct] then | ||
| global_tweaks["inpage_footnote_text_force_size"] = true |
There was a problem hiding this comment.
The original footnote font size tweaks are named id = T("inpage_footnote_font-size_%1", pct), so you're missing inpage_footnote_ on line 896 ?
| local fb2_notes_rem = 0.75 * rem / 0.8 | ||
| local fb2_comments_rem = 0.85 * rem / 0.8 |
There was a problem hiding this comment.
If going with that, you'll probably want to format these to 2 digits after the dot.
|
(Haven't read yet your other alternative PR.) I would have no real problem with the dynamic building. What I don't really like is having the footnote text long and including all the specific FB2 stuff. |
|
I think you convinced me that #13613 is better, so I'm closing this. It's very hard to keep these dynamic ones small enough to also serve as docs/tutorial. |
Alternative to #13613 that
This is done by introducing dynamic footnote tweaks that can change based on which other tweaks are set.
In short:
The dynamic style hint displays the current css in the popup, but there's no way to see other possible instantiations, which is a bit of a downside. I'm honestly not completely sure if it's worth the complexity compared to just keeping the "smaller" footnotes (maybe with #13613 as a small cleanup)
@poire-z I think this might address your concerns from #5863 (comment) / #5863 (comment), though obviously at the cost of complexity.
Note: I don't know if I got the fb2 hints right, might need someone to check or point me at a free fb2 book with footnotes & endnotes to test with.
This change is