kopt: improve OCR user experience#12497
Conversation
Differentiate between a failure to initialize tesseract data (bad or missing), and OCR failed (no results).
affcd1a to
213d911
Compare
|
So what's the point of |
|
It does say "not implemented yet". :-) As you probably noticed it says this where it's designed to use it: koreader/frontend/apps/reader/modules/readerhighlight.lua Lines 1644 to 1659 in 5b2cc5f My guess is it was intended as a follow-up to koreader/libk2pdfopt@537d0a5 Based on I'll note that this has already changed in |
|
So that comment is wrong and misleading ("is not implemented in some document backends"). |
|
It would seem so. |
|
OK, so another libk2pdfopt change and corresponding base update is going to be needed… In no particular order:
|
|
All sounds good. 👍 |
Possibly related: I never looked into it, but there's potentially a fair number of old open issues about crashes on CJK when OCR and/or reflow are involved (issues that, IIRC, may have started since the previous mupdf bump ages ago ;)). |
Differentiate between a failure to initialize tesseract data (bad or missing), and OCR failed (no results).
Initialization failed:

No results:

This change is