Bug fix: update page_turning_inverted icon/text#12386
Conversation
…order is updated in reader UI, not in settings. Note that reader UI loads inverse_reading_order from settings and then maintains it, allowing users to frequently change this value (e.g. when switching the device between hands.)
| if G_reader_settings:isTrue("input_invert_page_turn_keys") or | ||
| G_reader_settings:isTrue("input_invert_left_page_turn_keys") or | ||
| G_reader_settings:isTrue("input_invert_right_page_turn_keys") or | ||
| footer.ui.view.inverse_reading_order then |
There was a problem hiding this comment.
This feels a bit suspicious. If G_reader_settings:isTrue("inverse_reading_order") won't do the trick that may well be a problem because the menu also depends on that for example. In which case it should presumably also be updated here to resolve the problem globally:
koreader/frontend/apps/reader/modules/readerview.lua
Lines 1136 to 1142 in 698fc35
But that's just a quick note before heading off to bed; I may have overlooked something.
There was a problem hiding this comment.
Hi @Frenzie , inverse_reading_order is a per-document setting, that is, you can set different values for each book. This makes sense as different books may use different languages and layouts. The global setting of inverse_reading_order is more of a default value.
ReaderView loads and saves the per-document value:
A more illustrative reference is:
koreader/frontend/ui/elements/page_turns.lua
Lines 117 to 126 in 698fc35
This code snippet:
- Appends ★ to the menu text when the global default value is true.
- Checks the menu when the per-document value is true, which may or may not equals to the global value.
@Commodore64user FYI.
There was a problem hiding this comment.
inverse_reading_order is a per-document setting
I don't think that's a relevant detail wrt my comment, but that it does it the same way elsewhere may be fair enough.
|
Seeing as this hasn't even made it to a stable release, I am |
Hi @Commodore64user , thank you for contributing the great feature in the first place. Sorry that I didn't check the history and reported the issue I found earlier. I have different opinion regarding #12388 and replied there. |
| if G_reader_settings:isTrue("input_invert_page_turn_keys") or | ||
| G_reader_settings:isTrue("input_invert_left_page_turn_keys") or | ||
| G_reader_settings:isTrue("input_invert_right_page_turn_keys") or | ||
| footer.ui.view.inverse_reading_order then |
There was a problem hiding this comment.
Can be footer.view.inverse_reading_order.
koreader/frontend/apps/reader/modules/readerview.lua
Lines 127 to 130 in 698fc35
No worries mate! but since this was my PR, please let me deal with it. |
|
Superceded by #12388. |
Bug fix: update page_turning_inverted icon/text when inverse_reading_order is updated in reader UI, not in settings.
Note that reader UI loads inverse_reading_order from settings and then maintains it, allowing users to frequently change this value (e.g. when switching the device between hands.)
This change is