ScreenSaver: Fix a bunch of weird corner-cases#12028
Merged
Merged
Conversation
Apparently, the refresh can be slow enough to race with the state switch, resulting in it being displayed at the wrong bitdepth. Fix koreader#12009
message i.e., we do *NOT* want to see the default "Sleeping" message shown *in conjunction* with the "reboot/poweroff" overlay messages. Re: koreader#12009 (comment)
Member
Author
|
(Rebase me) |
Member
Author
|
Wow, does that startup script diff look bad in the GH UI ;). It's slightly less confusing with a patience diff, but basically, it's trivial: the two top-level orig fb/cpufreq blocks have just been moved inside the rc != halt branch. (It's much, much clearer on Reviewable ^^). |
NiLuJe
commented
Jun 14, 2024
NiLuJe
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
Frenzie
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop touching the framebuffer state on poweroff/reboot to deal with this, as that was perfectly useless in these instances anyway ;).
Fix #12009
This change is