File browser reshuffle#11781
Conversation
| return not BookInfoManager:getSetting("unified_display_mode") | ||
| return filemanager_display_mode == "list_image_meta" | ||
| or filemanager_display_mode == "list_image_filename" | ||
| or filemanager_display_mode == "list_only_meta" |
There was a problem hiding this comment.
Maybe you can use something like
to shorten this and similar checks.
|
This PR conflicts and does not apply on a current nightly. It's been a while since you started your work, and you haven't updated it for the recent changes to coverbrowser.main.lua, the top 2 commits in: Dunno how this is solvable via GitHub web (dunno if you're using that or a real git command line), @hius07 may know what's the best way to resolve it. |
|
okay @poire-z I believe I resolved all the conflicts...? |
|
No, you need to rebase, you're still 47 commits behind master. |
bc032da to
12c3c19
Compare
From the makers of the wildly successful Sleep screen rework #11549 and the yet to be merged status bar makeover #11678, We present to you the 'new kid in town', the new file browser (file cabinet) menu.
There has been a far less aggressive approach here, most of the work pertains the reduction of "view modes" and rewording of settings. Some logic was added for the functioning of the simpler view modes but besides that no changes in functionality were added or removed.
I am conflicted about the use of the word "mosaic" here, as what we get is a standard grid view that has nothing to do with actual mosaics, I would love to hear what you think, should it go, should it stay?
the following screenshots were captured on a non-touch kindle 4, so some options might not appear there. Anyway without any further ado,
Here it is the menu upon opening:
after going to the
Library view:Inside
mosaic and list view properties:and finally, inside the
file managementsubmenu:Important
I would like to have the classic view properties greyed out when 'classic mode' NOT selected but the usual
enable functiondoes not work in that case, any help there would be greatly appreciated.Last but not least, thanks to @Frenzie for his help, patience and support.
This change is