CoverBrowser: fix cover cache check #2#11380
Merged
hius07 merged 2 commits intokoreader:masterfrom Jan 17, 2024
Merged
Conversation
Contributor
|
Looking at the changes, it seems you want cover_w/h even when not get_cover or has_cover ? In what situations ? |
Member
Author
|
koreader/plugins/coverbrowser.koplugin/bookinfomanager.lua Lines 879 to 884 in 30e39a7 Line 879, call without true as the 2nd arg.cover_w and cover_h are used by isCachedCoverInvalid.
|
Contributor
|
OK, you could also have just moved the 2 lines just before the bookinfo["cover_w"] = tonumber(row[num])
bookinfo["cover_h"] = tonumber(row[num+1])
if not get_cover then
-- don't bother making a blitbuffer
break
end
to avoid the 3 string comparisons on each column Btw, does this all work fine if, started from an empty bookinfo cache, having |
Member
Author
|
Yes, works fine with that case. |
poire-z
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #11375.
This change is