Skip to content

2022.10 crashes if DCREREADER_CONFIG_MARGIN_SIZES present in defaults.persistent.lua #9700

Description

@doozan

I got this when upgrading from something a few months old, maybe 2022.07:

---------------------------------------------
                launching...
  _  _____  ____                _
 | |/ / _ \|  _ \ ___  __ _  __| | ___ _ __
 | ' / | | | |_) / _ \/ _` |/ _` |/ _ \ '__|
 | . \ |_| |  _ <  __/ (_| | (_| |  __/ |
 |_|\_\___/|_| \_\___|\__,_|\__,_|\___|_|

 It's a scroll... It's a codex... It's KOReader!

 [*] Current time: 10/28/22-19:17:57
 [*] Version: v2022.10

ffi.load: libs/libutf8proc.so.2
ffi.load: blitbuffer
10/28/22-19:17:57 INFO  initializing for device Kobo_star 
10/28/22-19:17:57 INFO  framebuffer resolution: {
  h = 1024,
  w = 758
} --[[table: 0x2b0b2518]] 
[ko-input] Forked off fake event generator (pid: 26837)
10/28/22-19:17:57 WARN  Device:getKeyRepeat: EVIOCGREP ioctl failed: Function not implemented 
ffi.load: libs/libmupdf.so
ffi.load: libs/libwrap-mupdf.so
10/28/22-19:17:57 INFO  Performing one-time migration for 20220819 
10/28/22-19:17:57 INFO  Performing one-time migration for 20220914 
10/28/22-19:17:57 INFO  Performing one-time migration for 20220930 
./luajit: ./defaults.persistent.lua:27: attempt to call global 'DCREREADER_CONFIG_MARGIN_SIZES' (a nil value)
stack traceback:
	./defaults.persistent.lua:27: in function 'load_defaults'
	frontend/ui/data/onetime_migration.lua:459: in main chunk
	[C]: in function 'require'
	./reader.lua:189: in main chunk
	[C]: at 0x000140bd
!!!!

related contents of defaults.persistent.lua:

-- page margins {left, top, right, bottom} in pixels
DCREREADER_CONFIG_MARGIN_SIZES {5, 2, 5, 5}

commenting out the DCREREADER_CONFIG_MARGIN_SIZES line fixed the crash, but it would have been a nicer user experience if it had ignored or converted the value instead of crashing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions