Skip to content

Github action for doc Build#1

Closed
yparitcher wants to merge 5 commits into
koreader:gh-pagesfrom
yparitcher:gh-pages
Closed

Github action for doc Build#1
yparitcher wants to merge 5 commits into
koreader:gh-pagesfrom
yparitcher:gh-pages

Conversation

@yparitcher

@yparitcher yparitcher commented Oct 27, 2021

Copy link
Copy Markdown
Member

I am trying a test so we can run this localy triggered by koreader build


This change is Reviewable

@yparitcher yparitcher marked this pull request as ready for review October 27, 2021 19:24
@yparitcher yparitcher marked this pull request as draft October 28, 2021 00:03
@yparitcher

Copy link
Copy Markdown
Member Author

@Frenzie
Can anyone help me why ldoc is not creating the html directory with the built docs?
https://github.com/yparitcher/doc/runs/4029336049?check_suite_focus=true

When tis is finished it should allow us to call it from koreaders action without having to create secrets etc.

Comment thread .github/workflows/docs.yml Outdated
container:
image: koreader/koappimage:0.1.8
# for now until docker crash fixed
#image: koreader/koappimage:0.2.2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really matter, but I doubt ldoc crashes?

Comment thread .ci/docs.sh
@Frenzie

Frenzie commented Oct 28, 2021

Copy link
Copy Markdown
Member

I don't think I can run workflows on your fork.

Since git and ldoc is all we need here, it might be a lot easier to get it working if we drop all the scaffolding?

@yparitcher

Copy link
Copy Markdown
Member Author

I don't think I can run workflows on your fork.

Since git and ldoc is all we need here, it might be a lot easier to get it working if we drop all the scaffolding?

It is a manual workflow so i have to trigger it.

I thought i had gotten rid of docker :) works much better now.

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good :)

Comment thread .ci/docs.sh

pushd ../koreader/doc && {
ldoc .
whoami

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer necessary.


steps:
# make sure we have git >= 2.18 so github checkout behaves
- name: Update ldoc

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install

@yparitcher

Copy link
Copy Markdown
Member Author

Thanks for the help, I found a better way to do this will post back in koreader

@yparitcher yparitcher closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants