CSS: add support for "ruby-position: over/under/alternate"#652
Conversation
No support for "inter-character". (Also add forgotten inheritance flag to caption-side.)
|
Keeping here the full description Copilot has updated in the top post of poire-z#3, for reference: This PR adds classic CSS parsing/handling for What’s included
Rendering behavior implementedRuby table rows are reordered visually based on each annotation row’s own Final logic is a simplified single-pass approach:
This preserves expected stacking behavior around the base while keeping the implementation compact. Notes
|
Frenzie
left a comment
There was a problem hiding this comment.
Looks cleaner than I'd expect from an LLM (but that's probably you ;-)
|
It was quite simple, mostly some copy & paste of some other similar property (the AI actually picked the most similar one, caption-side), but it still forgot a few things. I tried ChatGPT "Codex" this time, and it was a lot less cherful than Claude :) |
Fix crash when called from getBalancedHTML() (where no style is set) and meeting MathML elements. We don't need to do any of our MathML handling (adding attributes, wrappping in MathBox) when in this context, known by the fact the document has no style set.
No support for "inter-character".
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/ruby-position
https://drafts.csswg.org/css-ruby-1/#rubypos
Should allow closing koreader/koreader#14970.
(Also add forgotten inheritance flag to caption-side.)
Done with the help of Github copilot by guiding it step by step, full Copilot conversation/copiloting in poire-z#3 (18 conversation posts, 9 commits).
Also include:
MathML: don't handle anything when no def style setFix crash when called from getBalancedHTML() (where no style is set) and meeting MathML elements. We don't need to do any of our MathML handling (adding attributes, wrappping in MathBox) when in this context, known by the fact the document has no style set.
Should allow closing koreader/koreader#14974
This change is