Better consistency in createXPointer(pt), more robust EPUB ToC ncx parsing#650
Merged
Merged
Conversation
Frenzie
approved these changes
Feb 2, 2026
5937958 to
bfb7f7c
Compare
bfb7f7c to
da5ce2f
Compare
As they may have children with valid href.
Mostly "warning: 'xyz' may be used uninitialized". Also add forgotten ctxFlag to xpFirstLetter.getRect() and remove unused prevCharRectCtx.
Previously, we would return a xpointer to the next glyph if our pt was in the right half of a glyph. Now, always return a xpointer to that glyph. Also, when pt is in the blank between words (caused by text justification), handle it as if part of previous word, which will return a xpointer to after the end of that word (so, usually to the start of next word).
da5ce2f to
9c51ca0
Compare
This was referenced Feb 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epub ncx TOC: don't skip items with invalid href
As they may have children with valid href.
Avoid some compiler warnings
Mostly "warning: 'xyz' may be used uninitialized".
Also add forgotten ctxFlag to xpFirstLetter.getRect() and remove unused prevCharRectCtx.
ldomDocument::createXPointer(pt): better consistency
Previously, we would return a xpointer to the next glyph if our pt was in the right half of a glyph. Now, always return a xpointer to that glyph.
Also, when pt is in the blank between words (caused by text justification), handle it as if part of previous word, which will return a xpointer to after the end of that word (so, usually to the start of next word).
Should allow fixing (with changes in cre.cpp) most of the issues notices all along koreader/koreader#12135.
This change is