Android Wifi Manager interface#65
Merged
Frenzie merged 5 commits intokoreader:masterfrom Oct 10, 2017
Merged
Conversation
Frenzie
reviewed
Oct 9, 2017
AndroidManifest.xml
Outdated
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | ||
| <uses-permission android:name="android.permission.WRITE_SETTINGS" /> | ||
| <uses-permission android:name="android.permission.INTERNET" /> | ||
| <uses-permission android:name="android.permission.ACCESS_WIFI_STATE"></uses-permission> |
Member
There was a problem hiding this comment.
Could you change the XML to self-close just like the rest?
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
Frenzie
reviewed
Oct 9, 2017
| import android.view.Window; | ||
| import android.util.DisplayMetrics; | ||
| import android.net.wifi.WifiManager; | ||
| import android.content.Context; |
Member
There was a problem hiding this comment.
Is there a particular reason it's here rather than grouped with the other android.content.*?
Frenzie
reviewed
Oct 10, 2017
| } | ||
|
|
||
| private WifiManager getWifiManager() { | ||
| return (WifiManager) this.getSystemService(Context.WIFI_SERVICE); |
Member
There was a problem hiding this comment.
Nitpick and sorry I missed it before, but this should be 8 spaces, not a tab. :-)
Contributor
Author
There was a problem hiding this comment.
Did I already wrote how stupid is replacing Tabs with 4 spaces?
Guys, come on, we're in 21 century ! :P
Member
There was a problem hiding this comment.
I prefer tabs over spaces myself, but I should point out that even if we used tabs it should've been two instead of one. :-P
added 2 commits
October 10, 2017 19:31
…woz123/android-luajit-launcher into upsteam/android-wifi-interface
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge/interface to enable,disable, check status Wifi on Android