Skip to content

Remove Boox Go7 from EDP driver and add support for Hisense Touch Lite#562

Merged
hugleo merged 6 commits into
koreader:masterfrom
jadehawk:master
Jun 18, 2025
Merged

Remove Boox Go7 from EDP driver and add support for Hisense Touch Lite#562
hugleo merged 6 commits into
koreader:masterfrom
jadehawk:master

Conversation

@jadehawk

@jadehawk jadehawk commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Removed Boox Go7 from EDP driver, and Added Support for Hisense Touch Lite

Reason: new
Commercial name of product: Hisense Touch Lite
Android version: 11

Device info:
Manufacturer: hisense
Brand: hisense
Model: hitv205n
Device: hitv205n
Product: hitv205n
Hardware: qcom
Platform: bengal

light control works with Tolino driver, but warmth doesn't work.
no e-ink driver works.

This change is Reviewable

jadehawk added 6 commits May 27, 2025 16:47
With Onyx SDK driver, it only takes about 10% of the "Brightness/Warm Slider Bar" to reach 100% brightness/Warm on the Boox Go7 device.

With ONYX ADB it takes advantage of the entire "Brightness/Warm Slider Bar" making the changes more gradual and pleasing.

I did not notice this on my first PR.
@QQRush Reported Onyx Boox Palma lights working with ONYX ADB Driver koreader/koreader#8482 (comment)
Due to intermittent black screen when device awakes from sleep. I was able to duplicate the issue consistently when the EDP driver was assigned to Onyx/Qualcomm even if it did work on the developer Test Page.

See: koreader/koreader#8482 (comment)
@hugleo

hugleo commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

In the past, the EDP driver automatically switch my device to a strange fast mode when using the refreshScreen method. Using the repaintEverything method to refresh fixed the issue. I didn't need it anymore since the problem was fixed in future firmware versions.

You can give it a try: #435

@jadehawk

jadehawk commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

In the past, the EDP driver automatically switch my device to a strange fast mode when using the refreshScreen method. Using the repaintEverything method to refresh fixed the issue. I didn't need it anymore since the problem was fixed in future firmware versions.

You can give it a try: #435

Screenshot 2025-06-16 214227
@hugleo
If it's as simple as messing with this 2 lines of code, then I can report no combination helped. I still got the Black Screen. And the actual EDP driver did not work during the test screen on KOReader unless it was set to "refreshScreen".

So back to no EDP for Boox Go7 at this time.

At this moment I think it's best to remove the EDP support from the current "merge PR #556" before it makes it to the "stable" build.
Video

@hugleo

hugleo commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

In the past, the EDP driver automatically switch my device to a strange fast mode when using the refreshScreen method. Using the repaintEverything method to refresh fixed the issue. I didn't need it anymore since the problem was fixed in future firmware versions.
You can give it a try: #435

Screenshot 2025-06-16 214227 @hugleo If it's as simple as messing with this 2 lines of code, then I can report no combination helped. I still got the Black Screen. And the actual EDP driver did not work during the test screen on KOReader unless it was set to "refreshScreen".

So back to no EDP for Boox Go7 at this time.

At this moment I think it's best to remove the EDP support from the current "merge PR #556" before it makes it to the "stable" build. Video

repaintEverything doesn't have parameters that's is why refresh didn't work: .invoke(targetView, UI_GC_MODE). However, even attempting to call a non-existent method shouldn't necessarily be an EPD fault. It might be related to threading or sleep time.

The last thing I can think of is this: https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/device/DeviceInfo.kt#L638.

But we would need proper ADB logs to get a clue, suspect firmware fault, you can reach onyx support as well. So, yes, let's merge without EPD for now to keep things stable.

@hugleo hugleo changed the title Removed Boox Go7 from EDP driver, and Added Support for Hisense Touch Lite (ref#https://github.com/koreader/koreader/issues/8482#issuecomment-2975018122) Remove Boox Go7 from EDP driver and add support for Hisense Touch Lite Jun 17, 2025
@hugleo hugleo self-requested a review June 17, 2025 12:57
@hugleo hugleo merged commit 3468bdb into koreader:master Jun 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants