Fix arrow key scrolling in hex dump view#312
Merged
brkzlr merged 2 commits intokorcankaraokcu:masterfrom Feb 10, 2026
Merged
Conversation
Collaborator
|
Tested it and it seems to work well. There's just one slight issue if I may: When you scroll up/down once you reach the row limit, the selection highlight seems to stay at the previous value before the scroll started instead of following the actual current cell. |
Contributor
Author
|
Updated, the selection should now follow the current cell when scrolling at the boundary. Thanks for testing! |
Collaborator
|
Works fine now, thanks for the PR. |
Contributor
Author
|
Thanks for the quick review and merge! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #310
Summary
scroll_requestedsignal toQHexViewthat fires when pressing Up at row 0 orDown at the last row
MemoryViewerWindowto scroll the hex dump by one row (16bytes)
QAsciiViewinherits fromQHexView, the fix applies to both hex and ASCIIpanels
Test plan