fix(general): field and variable names #4911
Conversation
ecfb08f to
5a1bff7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4911 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.15%
==========================================
Files 470 538 +68
Lines 37301 31235 -6066
==========================================
- Hits 28299 24370 -3929
+ Misses 7071 4820 -2251
- Partials 1931 2045 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5a1bff7 to
2cd7b58
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes naming inconsistencies in the CleanupMarkersStats struct and related variables. The changes correct field names to use consistent capitalization ("Watermark" instead of "WaterMark") and rename local variables to be more descriptive by adding "Count" suffix.
Key changes:
- Renamed struct field from
DeletedDeletionWaterMarkBlobCounttoDeletedWatermarkBlobCountfor consistent capitalization - Renamed local variables from
deletedEpochMarkers/deletedDeletionWaterMarkstodeletedEpochMarkersCount/deletedWatermarksCountfor clarity - Updated all references including JSON tags, test data, and function calls
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| repo/maintenancestats/stats_cleanup_markers.go | Updated struct field name, JSON serialization, and summary message to use consistent "Watermark" capitalization |
| repo/maintenancestats/builder_test.go | Updated test cases to reflect the renamed struct field and JSON tag |
| internal/epoch/epoch_manager_test.go | Updated test assertion to use the renamed struct field |
| internal/epoch/epoch_manager.go | Renamed local variables for clarity and updated struct field assignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
FYI @Lyndon-Li |
Fixes field names in
CleanupMarkersStatspersistent struct.Also renames variables for consistency.