refactor(providers): change rclone's StartupTimeout type to Duration
#4528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25fa3f3 to
9c2fe2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
+ Coverage 75.86% 76.38% +0.51%
==========================================
Files 470 527 +57
Lines 37301 40047 +2746
==========================================
+ Hits 28299 30590 +2291
- Misses 7071 7441 +370
- Partials 1931 2016 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkowalski
approved these changes
Apr 28, 2025
This allows persistingand reading back the timeout as a duration. There are be no backwards compatibility issues, since the field is not currently set, so it is not persisted in the configuration file.
9c2fe2d to
df8cbbe
Compare
StartupTimeout type to Duration
Collaborator
Author
|
@jkowalski making it a duration is probably a better approach. PTAL (again), thanks. |
StartupTimeout type to DurationStartupTimeout type to Duration
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows persistingand reading back the timeout as a duration.
The name reflects the unit used for the timeout.There are be no backwards compatibility issues, since the field is
not currently set, so it is not persisted in the configuration file.