fix(revive): unused-parameter exclusion #4520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
julio-lopez
requested changes
Apr 25, 2025
| _ = contentID | ||
| func (c passthroughContentCache) Close(_ context.Context) {} | ||
|
|
||
| func (c passthroughContentCache) GetContent(ctx context.Context, _ string, blobID blob.ID, offset, length int64, output *gather.WriteBuffer) error { |
Collaborator
There was a problem hiding this comment.
The previous form is preferred because it explicitly calls out what that parameter was supposed to be.
Collaborator
There was a problem hiding this comment.
@mmorel-35 My comment above was ambiguous.
The comment was referring only to the change for the contentID parameter.
And it was NOT referring to other changes in this PR, such as the ones for the ctx parameter.
Collaborator
|
Thanks @mmorel-35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove unused-parameter exclusion and fixes it with underscore field naming