fix(cli): fixed v0.18.0 failures when using v0.17.0-generated client config #4255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The issue was caused by newly-introduced field I've made a fix and added a test that verifies this e2e. |
5530449 to
d3688a4
Compare
This was caused by the client using key derivation algorithm from a config file (which did not have it when it was generated using old version of Kopia). Fixes kopia#4254
d3688a4 to
a4194c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4255 +/- ##
==========================================
+ Coverage 75.86% 76.04% +0.17%
==========================================
Files 470 507 +37
Lines 37301 38913 +1612
==========================================
+ Hits 28299 29591 +1292
- Misses 7071 7363 +292
- Partials 1931 1959 +28 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
cc: @bathina2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by the client using key derivation algorithm from a config file (which did not have it when it was generated using old version of Kopia).
Fixes #4254