fix(server): ensure repo disconnection on server start exit
#3980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes '--password=xxx' parameter, which causes a server start failure due to incorrect repo password, and not for the case being checked, which is the lack of the "--insecure" parameter.
TestServerStartInsecureTestServerStartInsecure
a9185b4 to
d1b7a92
Compare
TestServerStartInsecureserver start
server startserver start exit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3980 +/- ##
==========================================
+ Coverage 75.86% 77.25% +1.39%
==========================================
Files 470 481 +11
Lines 37301 28806 -8495
==========================================
- Hits 28299 22255 -6044
+ Misses 7071 4655 -2416
+ Partials 1931 1896 -35 ☔ View full report in Codecov by Sentry. |
This was caught as a result of fixing a test.
d1b7a92 to
06229ed
Compare
julio-lopez
commented
Jul 12, 2024
| e.RunAndExpectFailure(t, "server", "start", "--ui", "--address=localhost:0", "--without-password", "--tls-generate-cert") | ||
|
|
||
| // server fails to start when TLS is not configured and `--insecure` is not specified | ||
| e.RunAndExpectFailure(t, "server", "start", "--ui", "--address=localhost:0") |
Collaborator
Author
There was a problem hiding this comment.
This is the modified test case, see first commit in this PR. It was:
e.RunAndExpectFailure(t, "server", "start", "--ui", "--address=localhost:0", "--password=foo")| // server fails to start without a password but with TLS. | ||
| e.RunAndExpectFailure(t, "server", "start", "--ui", "--address=localhost:0", "--tls-generate-cert", "--without-password") | ||
| // server fails to start with --without-password when `--insecure` is not specified | ||
| e.RunAndExpectFailure(t, "server", "start", "--ui", "--address=localhost:0", "--without-password") // without TLS |
Collaborator
Author
There was a problem hiding this comment.
Code movement only to group these cases. This was originally the last case.
Collaborator
Author
|
@redgoat650 @plar PTAL |
Collaborator
Author
|
@jkowalski FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure repository disconnection at the end of the
server startCLI command.This was caught as a result of fixing the test below.
Fix
TestServerStartInsecure:Remove
--password=xxxparameter, which causes a server start failure due to incorrect repo password, and not for the case being checked, which is the lack of the--insecureparameter.Update test comments accordingly.