fix(general): avoid panic on hashing password error #3907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3907 +/- ##
==========================================
+ Coverage 75.86% 77.12% +1.26%
==========================================
Files 470 479 +9
Lines 37301 28757 -8544
==========================================
- Hits 28299 22180 -6119
+ Misses 7071 4673 -2398
+ Partials 1931 1904 -27 ☔ View full report in Codecov by Sentry. |
…word Refactoring to propagate error encountered in an internal function.
Instead, propagate the error up the call stack
640b130 to
60c2dff
Compare
Collaborator
Author
|
@bathina2 FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: this code path is primarily executed from the server. A potential error, say from a corrupt, unsupported or otherwise invalid user profile should not cause the server to panic (and crash).
It is possible for
computePasswordHashto return an error, not just an impossibility.The issue was introduced in #3725