feat(providers): Add ExtendBlobRetention support for Azure
#3405
Conversation
ExtendBlobRetention support for Azure
just dont merge until ready to merge kopia#3412
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3405 +/- ##
==========================================
+ Coverage 75.81% 75.86% +0.04%
==========================================
Files 465 465
Lines 37180 37180
==========================================
+ Hits 28189 28207 +18
+ Misses 7059 7047 -12
+ Partials 1932 1926 -6 ☔ View full report in Codecov by Sentry. |
ExtendBlobRetention support for AzureExtendBlobRetention support for Azure
julio-lopez
left a comment
There was a problem hiding this comment.
This PR should go in with the one that depends on it as well, since that one has the tests :)
Merging this one now to move forward ;)
@KastenMike For future reference, it often makes sense to submit small trivial changes, such as typo corrections in their own PR. The reasons being - those are trivial to review and thus can be easily merged right away;
- and then they reduce noise in the PRs that have functional changes, so those become easier to review.
| // Compliance - compliance mode. | ||
| Compliance RetentionMode = "COMPLIANCE" | ||
|
|
||
| // Locked - Locked policy mode for Azure. |
There was a problem hiding this comment.
We should include "unlocked" as well.
|
@KastenMike also, thanks again for breaking things into smaller pieces to facilitate reviewing. |
|
@redgoat650 FYI |
Adds
ExtendBlobRetentioncode for Azure and fixes a couple typos I saw.