fix(providers): fixed rclone connection in KopiaUI #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.10.3 introduced a regression where RClone connections did not work in KopiaUI but were ok in the CLI. The root cause was #1691 which caused storage context to be closed after opening the repository. Added test that verifies that storage does not rely on the context remaining open.
Shrekster
reviewed
Feb 3, 2022
| ctx := testlogging.Context(t) | ||
|
|
||
| st, err := azure.New(ctx, &azure.Options{ | ||
| // use context that gets canceled after storage is initialize, |
Collaborator
There was a problem hiding this comment.
nit; initialize -> initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.10.3 introduced a regression where RClone connections did not
work in KopiaUI but were ok in the CLI.
The root cause was #1691 which caused storage context to be closed
after opening the repository.
Added test that verifies that storage does not rely on the context
remaining open.