refactor(general): make purpose a string parameter
#5015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make variables local to the test and rename accordingly - make the purpose a `const (untyped) string`
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the purpose parameter in key derivation functions from []byte to string, simplifying the API and removing unnecessary byte slice conversions throughout the codebase.
Key changes:
- Modified
DeriveKeyFromMasterKeyfunction signature to acceptpurposeasstringinstead of[]byte - Converted several
purposevariables from byte slice variables to string constants - Updated all call sites and test code to use string literals instead of byte slices
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/crypto/key_derivation.go | Changed function signature and removed string conversion of purpose parameter |
| internal/crypto/aesgcm.go | Converted purpose constants from byte slices to strings |
| internal/crypto/key_derivation_test.go | Updated test variables to use string constant and renamed to follow Go naming conventions |
| repo/repository.go | Updated interface and implementation signatures to accept string purpose |
| repo/open.go | Changed purpose variable from byte slice to string constant |
| repo/maintenance/maintenance_schedule.go | Moved purpose from variable to constant and changed type to string |
| repo/repository_test.go | Updated test to use string constant instead of byte slice |
Collaborator
Author
|
@miquella PTAL |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5015 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.15%
==========================================
Files 470 548 +78
Lines 37301 31398 -5903
==========================================
- Hits 28299 24497 -3802
+ Misses 7071 4850 -2221
- Partials 1931 2051 +120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.