chore(ci): pass context in helpers for running docker #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julio-lopez
commented
Nov 19, 2025
- Ref: chore(ci): enable noctx linter #4972
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Docker command execution in test utilities by adding context support for better cancellation handling and timeout control. The changes enable Docker commands to respect test context cancellations while preserving the ability to perform cleanup operations even after test completion.
Key Changes:
- Added context parameter to Docker execution functions for proper cancellation handling
- Introduced internal helper function to support both context-aware and cleanup scenarios
- Used
context.Background()for cleanup operations that must complete after test context cancellation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5012 +/- ##
==========================================
+ Coverage 75.86% 78.04% +2.17%
==========================================
Files 470 548 +78
Lines 37301 31398 -5903
==========================================
- Hits 28299 24505 -3794
+ Misses 7071 4844 -2227
- Partials 1931 2049 +118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8bd7fd4 to
5102fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.