chore(ci): cleanup TestKopiaRunner
#5010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julio-lopez
commented
Nov 19, 2025
- removes unnecessary cleanup deferred function
- use require to check expected invariants
Cleanup is done via `t.Setenv(...)`
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TestKopiaRunner test to improve code quality by removing an unnecessary cleanup function and modernizing assertion style using testify/require.
- Removes redundant deferred environment variable cleanup (handled by
t.Setenv) - Replaces manual error checking with testify/require assertions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5010 +/- ##
==========================================
+ Coverage 75.86% 78.07% +2.20%
==========================================
Files 470 548 +78
Lines 37301 31398 -5903
==========================================
- Hits 28299 24513 -3786
+ Misses 7071 4839 -2232
- Partials 1931 2046 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7bb2566 to
ae4a3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.