fix(cli): potential overflow in integer conversion #4993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4993 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.16%
==========================================
Files 470 548 +78
Lines 37301 31419 -5882
==========================================
- Hits 28299 24516 -3783
+ Misses 7071 4851 -2220
- Partials 1931 2052 +121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
commented
Nov 16, 2025
| } | ||
|
|
||
| v, err := strconv.ParseInt(str, 10, 64) | ||
| v, err := strconv.Atoi(str) |
Collaborator
Author
There was a problem hiding this comment.
Atoi already returns a platform-dependent int, it calls strconv.ParseInt(str, 10, 0)
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential integer overflow issue in the throttle setting functionality by using strconv.Atoi instead of strconv.ParseInt followed by an int conversion. This change eliminates the risk of overflow when converting a 64-bit integer to a platform-dependent int type.
Key Changes
- Replaced
strconv.ParseInt(str, 10, 64)withstrconv.Atoi(str)to parse directly to int - Removed explicit
int(v)conversion sincestrconv.Atoialready returns an int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.