chore(ci): build kopia with -trimpath
#4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
commented
Nov 13, 2025
Makefile
Outdated
| export KOPIA_VERSION_NO_PREFIX=$(KOPIA_VERSION:v%=%) | ||
|
|
||
| KOPIA_BUILD_TAGS= | ||
| KOPIA_BUILD_FLAGS=-ldflags "-trimpath -s -w -X github.com/kopia/kopia/repo.BuildVersion=$(KOPIA_VERSION_NO_PREFIX) -X github.com/kopia/kopia/repo.BuildInfo=$(shell git rev-parse HEAD) -X github.com/kopia/kopia/repo.BuildGitHubRepo=$(GITHUB_REPOSITORY)" |
Collaborator
Author
There was a problem hiding this comment.
-trimpath is added here
a70ee0a to
1ebcf59
Compare
1ebcf59 to
d031c54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4983 +/- ##
==========================================
+ Coverage 75.86% 78.03% +2.16%
==========================================
Files 470 548 +78
Lines 37301 31417 -5884
==========================================
- Hits 28299 24516 -3783
+ Misses 7071 4852 -2219
- Partials 1931 2049 +118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: move towards reproducible (hermetic) builds. The
-trimpathflag removes absolute file system paths from the resulting executables.Changes:
-trimpathtoKOPIA_BUILD_FLAGS-trimpathto goreleaser configKOPIA_BUILD_*var definitions toMakefile