chore(ci): enable wsl_v5:{assign,expr} linter settings
#4982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables two previously disabled wsl_v5 linter settings (assign and expr) that enforce whitespace formatting rules in Go code. The changes add blank lines before variable assignments and expressions throughout the codebase to comply with the newly enabled linter rules.
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Removes the disable directives for assign and expr settings in the wsl_v5 linter configuration |
| tests/robustness/pathlock/path_lock_test.go | Adds blank line before lock.Unlock() to separate from counter increment |
| tests/robustness/multiclient_test/framework/harness.go | Adds blank line before slice append operation |
| tests/end_to_end_test/snapshot_create_test.go | Adds blank lines after deferred disconnect calls and before repo operations |
| tests/end_to_end_test/snapshot_actions_test.go | Adds blank line after deferred file close |
| tests/end_to_end_test/shallowrestore_test.go | Adds blank line before array initialization |
| tests/end_to_end_test/server_start_test.go | Adds blank lines after variable declarations and before error checks |
| tests/end_to_end_test/restore_test.go | Adds blank line after deferred disconnect call |
| snapshot/upload/upload_test.go | Adds blank line after variable declaration |
| snapshot/upload/upload_estimator_test.go | Adds blank line after deferred close in goroutine |
| repo/repository_test.go | Adds blank line after deferred close before GetBlob call |
| repo/open.go | Adds blank line after return statement in unlock logic |
| repo/object/object_writer.go | Adds blank line after semaphore channel write |
| repo/manifest/manifest_manager_test.go | Adds blank line after variable declaration |
| repo/manifest/committed_manifest_manager.go | Adds blank lines around mutex-protected map assignment |
| repo/maintenance/maintenance_safety_test.go | Adds blank line after error variable declaration |
| repo/encryption/encryption_test.go | Adds blank line after deferred close |
| repo/encryption/chacha20_poly1305_hmac_sha256_encryptor.go | Adds blank line after hash buffer declaration |
| repo/encryption/aes256_gcm_hmac_sha256_encryptor.go | Adds blank lines after deferred Put call and after hash buffer declaration |
| repo/ecc/ecc_rs_crc.go | Adds blank lines after deferred closes and before buffer/array operations |
| repo/content/index/merged_test.go | Adds blank line after Info variable declaration |
| repo/content/index/index_v1.go | Adds blank line after constant declaration |
| repo/content/content_manager_test.go | Adds blank lines after deferred closes and before mutex operations |
| repo/blob/throttling/throttling_semaphore_test.go | Adds blank line before mutex unlock |
| repo/blob/s3/s3_versioned_test.go | Adds blank lines around mutex-protected random read |
| repo/blob/rclone/rclone_storage.go | Adds blank line after http.Client variable declaration |
| repo/blob/gcs/gcs_versioned_test.go | Reorganizes variable declarations with proper blank line spacing |
| repo/blob/azure/azure_versioned_test.go | Reorganizes variable declarations with proper blank line spacing |
| internal/sleepable/sleepable_timer_test.go | Adds blank line after deferred WaitGroup done |
| internal/server/server.go | Adds blank line after result variable declaration |
| internal/server/grpc_session.go | Adds blank line after TraceContext variable declaration |
| internal/parallelwork/parallel_work_queue.go | Adds blank line before mutex unlock |
| internal/metrics/metrics_duration_distribution_test.go | Adds blank lines after nil Registry variable declarations |
| internal/metrics/metrics_counter_test.go | Adds blank line after nil Registry variable declaration |
| internal/iocopy/iocopy_test.go | Adds blank line after ReleaseBuffer call |
| internal/hmac/hmac.go | Adds blank line after signature buffer declaration |
| internal/gather/gather_write_buffer.go | Adds blank line after deferred mutex unlock |
| internal/diff/diff_test.go | Adds blank lines after manifest ID slice declarations |
| internal/diff/diff.go | Adds blank line after args slice declaration |
| internal/contentlog/contentlog_logger_test.go | Adds blank lines after logEntry map variable declarations |
| internal/contentlog/contentlog_json_writer.go | Adds blank line after numBuf array declaration |
| cli/config.go | Adds blank line after channel select case |
| cli/command_snapshot_pin_test.go | Adds blank line after deferred disconnect call |
| cli/command_snapshot_migrate.go | Adds blank line before mutex unlock |
| cli/command_snapshot_list_test.go | Adds blank lines after deferred disconnect calls |
| cli/command_policy_edit.go | Adds blank line after bytes.Buffer variable declaration |
| cli/command_content_verify.go | Adds blank line after deferred WaitGroup done |
| cli/app.go | Adds blank line before exitWithError call |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4982 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.16%
==========================================
Files 470 548 +78
Lines 37301 31417 -5884
==========================================
- Hits 28299 24514 -3785
+ Misses 7071 4852 -2219
- Partials 1931 2051 +120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.