refactor(ci): enable wsl_v5:return linter #4975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4975 +/- ##
==========================================
+ Coverage 75.86% 78.05% +2.18%
==========================================
Files 470 548 +78
Lines 37301 31429 -5872
==========================================
- Hits 28299 24532 -3767
+ Misses 7071 4849 -2222
- Partials 1931 2048 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enables the wsl_v5:return linter rule to enforce blank lines before return statements in Go code, improving code readability and consistency across the codebase.
Key Changes:
- Enabled the
wsl_v5:returnlinter rule by removing it from the disabled list in.golangci.yml - Added blank lines before return statements across 10 files to comply with the newly enforced linter rule
- Added clarifying comments explaining that
nakedretandnlreturnlinters are disabled because their rules are already enforced by stricter alternatives
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.golangci.yml |
Removed return from wsl_v5 disabled rules list and added comments explaining disabled nakedret and nlreturn linters |
tests/tools/fswalker/fswalker_test.go |
Added blank lines before return statements in test helper functions |
repo/repository_test.go |
Added blank lines before return statements in test callback functions |
repo/manifest/manifest_manager_test.go |
Added blank line before return statement in test case function |
repo/maintenance/maintenance_run.go |
Added blank line before return statement after log message |
repo/compression/compressor_zstd.go |
Added blank line before return statement in sync.Pool initializer |
repo/compression/compressor_pgzip.go |
Added blank line before return statement in sync.Pool initializer |
repo/compression/compressor_gzip.go |
Added blank line before return statement in sync.Pool initializer |
notification/notifytemplate/embeddedtemplate.go |
Added blank line before return statement after sort operation |
internal/retry/retry_test.go |
Added blank line before return statement in test case function |
cli/app.go |
Added blank line before return statement after exitWithError call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.