feat(general): add stats to maintenance run - SnapshotGC #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4964 +/- ##
==========================================
+ Coverage 75.86% 78.03% +2.16%
==========================================
Files 470 548 +78
Lines 37301 31429 -5872
==========================================
- Hits 28299 24526 -3773
+ Misses 7071 4852 -2219
- Partials 1931 2051 +120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
previously approved these changes
Nov 10, 2025
Collaborator
julio-lopez
left a comment
There was a problem hiding this comment.
LG overall.
See inline:
- question about the name for a couple of the fields https://github.com/kopia/kopia/pull/4964/files#r2508641996 ; and
- comment about the user-facing logs that were there before, with human-readable units.
d334750 to
a9cb9a3
Compare
julio-lopez
approved these changes
Nov 10, 2025
Collaborator
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance is critical for healthy of the repository.
On the other hand, Maintenance is complex, because it runs multiple sub tasks each may generate different results according to the maintenance policy. The results may include deleting/combining/adding data/metadata to the repository.
It is worthy to add more observability for these tasks for below reasons:
There will be a serial of PRs to add observability info for each sub task.
The current PR add the stats info for SnapshotGC sub task.