refactor(general): leverage stats.CountSum in maintenance stats
#4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rite Rationale: simplifies code
In kopia, "blob" is a generic term to refer to either an object in an object storage provider, or a file in a file system storage provider. There are various types of blobs in a kopia repository. In kopia, "pack" is used to refer to specific types of blobs, namely 'p' & 'q' pack blobs, that store "content" data, as opposed to say, "index" blobs. This change attempts to use the term "pack" consistently in the functions and types used for pack deletion. Note that the corresponding task names, shown below, remain unchanged since these names are used in the persistent maintenance run metadata, and that is used to make decisions about the safety of the execution of those tasks. ``` TaskDeleteOrphanedBlobsQuick = "quick-delete-blobs" TaskDeleteOrphanedBlobsFull = "full-delete-blobs" ```
There was a problem hiding this comment.
Pull Request Overview
This PR refactors maintenance statistics handling by replacing manual mutex-protected counters with the thread-safe stats.CountSum type, and corrects terminology and spelling issues throughout the maintenance code.
Key changes:
- Replaces mutex-protected counter variables with
stats.CountSumfor thread-safe statistics tracking - Corrects spelling and grammar in comments and error messages
- Updates terminology from "blob" to "pack" for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| repo/maintenancestats/stats_rewrite_contents.go | Fixes spelling errors in comments and improves grammar in summary message |
| repo/maintenance/maintenance_run.go | Updates terminology from "blob" to "pack" in log messages and error descriptions for consistency |
| repo/maintenance/content_rewrite.go | Refactors statistics tracking to use stats.CountSum instead of mutex-protected variables, and updates failedCount to use atomic.Uint64 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4963 +/- ##
==========================================
+ Coverage 75.86% 78.06% +2.19%
==========================================
Files 470 547 +77
Lines 37301 31407 -5894
==========================================
- Hits 28299 24518 -3781
+ Misses 7071 4844 -2227
- Partials 1931 2045 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.