feat(general): add stats to maintenance run - DeleteUnreferencedPacks #4955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce39da6 to
2fb19a5
Compare
Lyndon-Li
commented
Nov 5, 2025
julio-lopez
requested changes
Nov 5, 2025
Collaborator
julio-lopez
left a comment
There was a problem hiding this comment.
Looks good overall.
Requested change in the stats field names.
There was a problem hiding this comment.
Pull Request Overview
This PR adds observability statistics for the DeleteUnreferencedPacks maintenance task, enabling better tracking of blob deletion operations during repository maintenance.
Key Changes:
- Introduces a new
DeleteUnreferencedPacksStatsstruct to capture unreferenced, deleted, and retained blob counts and sizes - Updates
DeleteUnreferencedBlobsto return statistics instead of just a count - Adds tracking for retained blobs (those preserved due to cutoff time, minimum age, or active session constraints)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
repo/maintenancestats/stats_delete_unreferenced_packs.go |
Defines the new stats structure with JSON serialization and summary methods |
repo/maintenancestats/builder_test.go |
Adds test cases for serializing/deserializing the new stats type |
repo/maintenancestats/builder.go |
Registers the new stats kind in the builder factory |
repo/maintenance/maintenance_run.go |
Simplifies task runners to directly return stats from DeleteUnreferencedBlobs |
repo/maintenance/blob_gc.go |
Implements stats collection including retained blob tracking and returns structured stats |
cli/command_blob_gc.go |
Updates CLI command to use the new stats structure |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4955 +/- ##
==========================================
+ Coverage 75.86% 77.99% +2.13%
==========================================
Files 470 544 +74
Lines 37301 31353 -5948
==========================================
- Hits 28299 24455 -3844
+ Misses 7071 4851 -2220
- Partials 1931 2047 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2fb19a5 to
84b7e75
Compare
84b7e75 to
18b935f
Compare
julio-lopez
approved these changes
Nov 5, 2025
Collaborator
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance is critical for healthy of the repository.
On the other hand, Maintenance is complex, because it runs multiple sub tasks each may generate different results according to the maintenance policy. The results may include deleting/combining/adding data/metadata to the repository.
It is worthy to add more observability for these tasks for below reasons:
There will be a serial of PRs to add observability info for each sub task.
The current PR add the stats info for DeleteUnreferencedPacks sub task.