refactor(general): fix field names in CompactSingleEpochStats
#4947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julio-lopez
commented
Nov 3, 2025
- Followup to feat(general): add stats to maintenance run - CompactSingleEpoch #4941
There was a problem hiding this comment.
Pull Request Overview
This PR refactors field names in the CompactSingleEpochStats struct to be more descriptive and accurate. The changes rename fields from generic "compacted blob" terminology to more specific "superseded index" terminology to better reflect the actual purpose of these statistics.
Key changes:
- Renamed
CompactedBlobCounttoSupersededIndexBlobCountandCompactedBlobSizetoSupersededIndexTotalSize - Updated JSON field names and serialization methods accordingly
- Updated all references in tests and usage sites
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| repo/maintenancestats/stats_compact_single_epoch.go | Updated struct field names, JSON tags, serialization methods, and summary formatting |
| repo/maintenancestats/builder_test.go | Updated test cases to use new field names and expected JSON output |
| internal/epoch/epoch_manager_test.go | Updated test assertions to reference the renamed field |
| internal/epoch/epoch_manager.go | Updated struct initialization to use new field names |
335e118 to
8c6e401
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4947 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.16%
==========================================
Files 470 542 +72
Lines 37301 31309 -5992
==========================================
- Hits 28299 24430 -3869
+ Misses 7071 4838 -2233
- Partials 1931 2041 +110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.