refactor(general): use explicit return values #4940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves clarity, avoids 'naked' return and removes linter annotation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to replace naked return statements with explicit return values for improved code clarity and to satisfy linter requirements (nakedret and gofumpt).
- Replaced naked
returnstatements with explicit return values across multiple files - Removed associated
//nolint:nakedretcomments that are no longer needed - Maintained the same function behavior while improving code readability
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/robustness/snapmeta/kopia_snapshotter.go | Added explicit returns for snapshot creation and restoration functions |
| tests/robustness/robustness_test/main_test.go | Added explicit return for cleanup function |
| tests/robustness/engine/action.go | Added explicit returns for file operation action functions |
| snapshot/policy/retention_policy.go | Added explicit return for string prefix/suffix parsing function |
| repo/ecc/ecc_utils.go | Added explicit return for shard computation function |
| repo/ecc/ecc_rs_crc.go | Added explicit return for length reading function and removed nolint comment |
| repo/content/indexblob/index_blob_manager_v0.go | Added explicit return for blob deletion finding function |
| repo/blob/sharded/sharded.go | Added explicit returns for sharded path resolution function |
| repo/blob/sftp/sftp_storage_test.go | Added explicit returns for SFTP server startup test function and removed nolint comments |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4940 +/- ##
==========================================
+ Coverage 75.86% 78.00% +2.13%
==========================================
Files 470 540 +70
Lines 37301 31268 -6033
==========================================
- Hits 28299 24391 -3908
+ Misses 7071 4833 -2238
- Partials 1931 2044 +113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been controversy in the community about the use of naked
returnstatements.Given that two linters (
nakedretand soongofumpt) flag these, andgofumptdoes not have a configuration option for it, it makes sense to have explicit return values, for clarity, in the few instances where they are missing.