refactor(general): index.maxContentLengths #4932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- leverage `max` builtin - explicit return values (to satisfy linters)
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the maxContentLengths function to use Go's built-in max() function and explicitly return values to satisfy linter requirements.
- Replaced manual if-condition comparisons with
max()builtin calls - Added explicit return statement with named return values
- Simplified the function logic while maintaining the same functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4932 +/- ##
==========================================
+ Coverage 75.86% 78.00% +2.14%
==========================================
Files 470 540 +70
Lines 37301 31268 -6033
==========================================
- Hits 28299 24392 -3907
+ Misses 7071 4832 -2239
- Partials 1931 2044 +113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max(...)builtin