chore(ci): enable wsl:err linter settings
#4928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87dc64a to
bbabdbd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4928 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.16%
==========================================
Files 470 548 +78
Lines 37301 31417 -5884
==========================================
- Hits 28299 24514 -3785
+ Misses 7071 4852 -2219
- Partials 1931 2051 +120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48d99e1 to
1eaaa7a
Compare
1eaaa7a to
95958e1
Compare
95958e1 to
37ead6f
Compare
wsl:* linter settings
wsl:* linter settingswsl:err linter settings
There was a problem hiding this comment.
Pull Request Overview
This PR enables the wsl:err linter setting by removing it from the disabled list in .golangci.yml and cleaning up the codebase to comply with the linter rule. The wsl:err rule enforces proper whitespace handling around error checks by requiring no blank lines between error-generating statements and their error checks.
Key changes:
- Enabled
wsl:errlinter in.golangci.yml - Removed unnecessary blank lines before error checks in 4 files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.golangci.yml |
Removed err from the wsl linter's disabled rules list |
internal/wcmatch/wcmatch_test.go |
Removed blank line between NewWildcardMatcher call and error check |
internal/passwordpersist/passwordpersist_multiple.go |
Removed blank line between PersistPassword call and error check |
cli/command_snapshot_create.go |
Removed blank line between ParseSourceInfo call and error check |
cli/command_mount.go |
Removed blank line between mount call and error check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.