refactor(general): modernize bloop #4904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4904 +/- ##
==========================================
+ Coverage 75.86% 77.99% +2.12%
==========================================
Files 470 537 +67
Lines 37301 31216 -6085
==========================================
- Hits 28299 24347 -3952
+ Misses 7071 4831 -2240
- Partials 1931 2038 +107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes benchmark code by adopting Go's newer b.Loop() API, introduced in Go 1.24, which replaces the older for range b.N pattern. The changes simplify benchmark setup by eliminating the need for manual timer management.
- Replaces
for range b.Nwithb.Loop()across all benchmark functions - Removes manual
b.ResetTimer(),b.StopTimer(), andb.StartTimer()calls that are now handled automatically
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| repo/repo_benchmarks_test.go | Updates benchmark loop to use b.Loop() and removes manual timer reset |
| repo/manifest/manifest_manager_test.go | Converts benchmark loop to b.Loop() |
| repo/logging/logging_test.go | Updates benchmark loop and removes manual timer management |
| repo/encryption/encryption_test.go | Converts to b.Loop() and removes timer reset |
| repo/compression/compressor_test.go | Updates both compression and decompression benchmark loops |
| internal/workshare/workshare_test.go | Converts benchmark loop and removes timer management |
| fs/localfs/localfs_benchmark_test.go | Updates to b.Loop() and removes all manual timer calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.