Skip to content

Conversation

@yinheli
Copy link
Contributor

@yinheli yinheli commented Oct 11, 2025

This PR addresses #3542 by making the --progress flag visible and ensuring the sync-to command respects the global progress setting.

…umentation

- Update progress flag description from "progress bar" to "progress output" for clarity
- Document progress control features in Logging, Synchronization, and Command-Line reference
- Support --no-progress flag for cleaner automation and scripting usage
Copilot AI review requested due to automatic review settings October 11, 2025 02:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the --progress flag visible to users and ensures the sync-to command respects the global progress setting. Previously, the progress flag was hidden and the sync-to command didn't honor the user's progress preferences.

  • Removed the .Hidden() modifier from the --progress flag to make it visible in help output
  • Added progress control logic to the sync-to command to respect the global progress setting
  • Updated documentation to explain the progress flag and its usage in automation scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cli/cli_progress.go Made the --progress flag visible by removing .Hidden() modifier
cli/command_repository_sync.go Added progress control to sync-to command by checking progress state before output
site/content/docs/Reference/Command-Line/_index.md Added global flags documentation including the --progress flag
site/content/docs/Advanced/Synchronization/_index.md Added automation section explaining --no-progress usage for scripts
site/content/docs/Advanced/Logging/_index.md Added progress output section explaining progress control separate from logging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.78%. Comparing base (cb455c6) to head (0055bec).
⚠️ Report is 687 commits behind head on master.

Files with missing lines Patch % Lines
cli/command_repository_sync.go 14.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
+ Coverage   75.86%   76.78%   +0.92%     
==========================================
  Files         470      535      +65     
  Lines       37301    40939    +3638     
==========================================
+ Hits        28299    31436    +3137     
- Misses       7071     7457     +386     
- Partials     1931     2046     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-lopez julio-lopez changed the title feat: make --progress flag visible and respect it in sync-to command (#3542) fix(cli): make --progress flag visible and use it in sync-to command (#3542) Oct 15, 2025
@julio-lopez julio-lopez merged commit 3563fdd into kopia:master Oct 15, 2025
26 of 27 checks passed
@julio-lopez julio-lopez changed the title fix(cli): make --progress flag visible and use it in sync-to command (#3542) fix(cli): make --progress flag visible and use it in sync-to command Oct 15, 2025
@julio-lopez
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants