refactor(general): cleanup observabilityFlags #4852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It always calls the action with a repository
a065665 to
2bf450c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the observability and metrics functionality in the CLI, moving from individual metric collection to a more comprehensive diagnostics system.
- Consolidates observability operations into a single
run()method that handles tracing, metrics, and cleanup - Replaces individual metric file output with a structured diagnostics directory system
- Moves allocator stats dumping functionality from the main app to the observability module
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cli/observability_flags.go | Refactors observability infrastructure with new diagnostics directory structure, consolidated run method, and allocator stats integration |
| cli/app.go | Simplifies app structure by removing duplicate allocator stats handling and consolidating repository action methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4852 +/- ##
==========================================
+ Coverage 75.86% 76.60% +0.73%
==========================================
Files 470 536 +66
Lines 37301 41171 +3870
==========================================
+ Hits 28299 31537 +3238
- Misses 7071 7593 +522
- Partials 1931 2041 +110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily code movement.